Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPSTREAM] Fix openvino image reference (#921) #259

Conversation

lucferbux
Copy link

@lucferbux lucferbux commented Feb 1, 2023

Description

Fix issue with the deployed openvino image
Fix https://issues.redhat.com/browse/RHODS-6779

How Has This Been Tested?

  1. Create a cluster with pull secret to allow image fetching
  2. Create a malformed servingruntime-config configmap
  3. Create a new model serving and check the image is being pulled

You can check this too just doing podman pull registry.redhat.io/rhods/odh-openvino-servingruntime-rhel8@sha256:8af20e48bb480a7ba1ee1268a3cf0a507e05b256c5fcf988f8e4a3de8b87edc6

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-6779
  • The Jira story is acked.
  • Live build image: quay.io/lferrnan/rhods-operator-live-catalog:1.22.0-rhods-ga
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.

Fix openvino image reference ir order to be able to pull  it from there.
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrewballantyne
Copy link

👍 If this image works better than the last, looks good to me. We'll work on improving this upstream so this doesn't require a rebuild.

/approved

@anishasthana
Copy link
Member

Won't this commit also need to go into main?

@lucferbux
Copy link
Author

Won't this commit also need to go into main?

Nope, we fetch main directly from upstream, and same thing for the feature branches, only changing the path for hotfixes.

Copy link

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
verified using live build. Fix seems good

@lucferbux lucferbux merged commit 7156ce3 into red-hat-data-services:rhods-1.22 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants