Get real username when in cluster #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaoDaoNoCode
force-pushed
the
add-username
branch
from
eaa6be3
to
bb5bb33
Compare
jeff-phillips-18
requested changes
May 24, 2021
| @@ -30,6 +30,9 @@ export default async (fastify: FastifyInstance): Promise<void> => { | |||
| fastify.get('/', async (request, reply) => { | |||
| return status(fastify) | |||
| .then((res) => { | |||
| if (request.headers['x-forwarded-user']) { | |||
| (res.kube.currentUser as any) = request.headers['x-forwarded-user']; | |||
There was a problem hiding this comment.
Rather pass request to the status call and set the userName there.
jeff-phillips-18
approved these changes
May 24, 2021
crobby
pushed a commit
to crobby/odh-dashboard
that referenced
this pull request
Jun 3, 2021
anishasthana
pushed a commit
that referenced
this pull request
Jun 3, 2021
crobby
pushed a commit
that referenced
this pull request
Jun 3, 2021
crobby
pushed a commit
to crobby/odh-dashboard
that referenced
this pull request
Sep 15, 2021
starburst-blumbert
added a commit
to starburst-blumbert/odh-dashboard
that referenced
this pull request
May 6, 2022
Added in a new line (red-hat-data-services#84) to provide instructions for downloading the Jupyter notebook. Updated step numbers for lines 85 - 88 accordingly since a new step 1 was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use OpenShift oauth-proxy when the application is in a cluster, we can read the username directly from the headers
x-forwarded-userfield of the request that proxy transmits to the server.This PR changes the
statusAPI to read the username and send it back to the front-end.