Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OSD check to use an OpenShift configmap #227

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update OSD check to use an OpenShift configmap #227

merged 1 commit into from
Apr 13, 2022

Conversation

anishasthana
Copy link
Member

Signed-off-by: Anish Asthana anishasthana1@gmail.com

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-3454
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)
  • The developer has manually tested the changes and verified that the changes work.

@anishasthana
Copy link
Member Author

@pablofelix Live build is available at quay.io/anishasthana/rhods-operator-live-catalog:1.90.0-3454. It's upgrading from 1.8.0-14 as there isn't an official 1.9.0 build yet.

crobby
crobby reviewed Apr 6, 2022
View reviewed changes
deploy.sh Show resolved Hide resolved
crobby
crobby suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a log noting which env, AWS or "not", would help....maybe bonus points for the log entry indicating what else that will mean (the AWS DB getting created instead of local)

crobby
crobby approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anishasthana
Copy link
Member Author

quay.io/anishasthana/rhods-operator-live-catalog:1.92.0-3454 is the livebuild with the additional logging, in case anyone is interested!

accorvin
accorvin reviewed Apr 7, 2022
View reviewed changes
deploy.sh Outdated Show resolved Hide resolved
@accorvin
Copy link
Member

accorvin commented Apr 7, 2022

A thought: we should definitely make sure to test this on ROSA (or at least make sure that infrastructure shows up as AWS on an existing ROSA cluster) in addition to regular OSD.

@anishasthana
Copy link
Member Author

Hopefully final live build: quay.io/anishasthana/rhods-operator-live-catalog:1.97.0-3454

@accorvin
Copy link
Member

accorvin commented Apr 7, 2022

I'm spinning up a ROSA cluster to test this on now.

@accorvin
Copy link
Member

accorvin commented Apr 7, 2022 •
edited

I see this line in the odh-deployer pod on my ROSA cluster:
INFO: Deploying on AWS. Creating CRO for deployment of RDS Instance
So I think it's good.

@accorvin
Copy link
Member

accorvin commented Apr 7, 2022

Another update: I see the following on a PSI OSIA cluster:

INFO: Deploying on PSI. Creating local database

I can confirm that the CRO pod does not get created in PSI, and the PostgreSQL pod does.

So, everything looks good on both PSI and ROSA.

lucferbux
lucferbux approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucferbux
Copy link
Contributor

Checked on PSI, works great.

@anishasthana
Update OSD check to use an OpenShift configmap
a9f5e45 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@crobby crobby merged commit 45c0051 into red-hat-data-services:main Apr 13, 2022
@anishasthana anishasthana deleted the update_osd_check branch April 14, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaVLaS LaVLaS LaVLaS left review comments

@accorvin accorvin accorvin left review comments

@crobby crobby crobby approved these changes

@lucferbux lucferbux lucferbux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anishasthana @accorvin @lucferbux @crobby @LaVLaS