Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change apply to create command to prevent overwriting of jh-cfg #238

Merged
merged 1 commit into from Aug 6, 2022
Merged

Change apply to create command to prevent overwriting of jh-cfg #238

merged 1 commit into from Aug 6, 2022

Conversation

maroroman
Copy link
Contributor

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-4366
  • The Jira story is acked
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)
  • The developer has manually tested the changes and verified that the changes work.

Testing:

  1. Add custom values to the jupyterhub-cfg configmap
  2. Update or redeploy RHODS
  3. Verify that custom values are not overwritten

LaVLaS
LaVLaS approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maroroman maroroman changed the title Change create to apply command to prevent overwriting of jh-cfg Change apply to create command to prevent overwriting of jh-cfg Aug 2, 2022
@cfchase cfchase self-requested a review August 5, 2022 23:02
@cfchase
Copy link
Contributor

cfchase commented Aug 5, 2022

Tested with quay.io/mroman_redhat/rhods-operator-live-catalog:1.14.0-j4366-1 and my own live build (rebased from notebook controller branch). Both worked for me.

lgtm

@cfchase cfchase merged commit 1d90bdf into red-hat-data-services:main Aug 6, 2022
dimakis pushed a commit to dimakis/odh-deployer that referenced this pull request Jul 9, 2023
@maroroman
Change create to apply command (red-hat-data-services#238)
764094e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaVLaS LaVLaS LaVLaS approved these changes

@cfchase cfchase Awaiting requested review from cfchase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maroroman @cfchase @LaVLaS