Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PVC Usage Metrics #253

Merged
merged 1 commit into from Aug 5, 2022

Conversation

VaishnaviHire
Copy link
Contributor

@VaishnaviHire VaishnaviHire commented Aug 4, 2022

Description

After previous changes in Federation route, we no longer get duplicate entries for the metrics. This commit updates PVC
usage metrics to remove prometheus_replica from the alerting rules.

How Has This Been Tested?

  1. Deploy RHODS instance
  2. Manually run https://github.com/redhat-rhods-qe/ods-ci-notebooks-main/blob/main/notebooks/200__monitor_and_manage/203__alerts/notebook-pvc-usage/fill-notebook-pvc-over-90.ipynb to verify if alerts are getting triggered
  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-4797
  • The Jira story is acked.
  • Live build image: quay.io/vhire/rhods-operator-live-catalog:1.15.0-rhods-4797
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • QE contact acknowledges that this has been tested and is approved for merge.

@openshift-ci openshift-ci bot requested review from crobby and lucferbux August 4, 2022 12:51
@VaishnaviHire VaishnaviHire changed the title [WIP] Update PVC Usage Metrics Update PVC Usage Metrics Aug 4, 2022
@crobby
Copy link
Contributor

crobby commented Aug 4, 2022

Screenshot from 2022-08-04 12-49-12
Looks right to me

Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this working well.

Copy link

@pablofelix pablofelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change work as expected.

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, crobby, pablofelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [anishasthana,crobby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samuelvl
Copy link
Contributor

samuelvl commented Aug 5, 2022

/label qe-approved

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@samuelvl: The label(s) qe-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelvl
Copy link
Contributor

samuelvl commented Aug 5, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved The PR has been approved by the QE team label Aug 5, 2022
@openshift-ci openshift-ci bot merged commit e2cba7f into red-hat-data-services:main Aug 5, 2022
dimakis pushed a commit to dimakis/odh-deployer that referenced this pull request Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe-approved The PR has been approved by the QE team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants