Remove explicit CUDA version from imagestreamtag #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to RHODS-4312 which notes that in some cases a driver update can occur without a corresponding update to RHODS, leaving the spawner showing a CUDA version that is inconsistent with the version displayed in the notebook at runtime. It might be a good idea to get this from the driver somehow, but since that requires a lot of rearchitecting, this just removes the explicit version from the mouseover text
|
Live build in progress, @anishasthana @tarukumar PTAL |
|
Live build was successful |
|
Can you share the live build here for testing? |
|
quay.io/modh/odh-deployer-container-live:1.18.0-rhods-4312 |
|
/lgtm This worked for me |
LaVLaS
approved these changes
Sep 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dimakis
pushed a commit
to dimakis/odh-deployer
that referenced
this pull request
Jul 9, 2023
Remove explicit CUDA version from imagestreamtag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to RHODS-4312 which notes that in some cases a driver update can occur without a corresponding update to RHODS, leaving the spawner showing a CUDA version that is inconsistent with the version displayed in the notebook at runtime. It might be a good idea to get this from the driver somehow, but since that requires a lot of rearchitecting, this just removes the explicit version from the mouseover text
[UPSTREAM]has been prepended to the commit message.