Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dashboard-oauth-config secret when upgrading from 1.18 #278

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Delete dashboard-oauth-config secret when upgrading from 1.18 #278

merged 1 commit into from
Nov 16, 2022

Conversation

samuelvl
Copy link
Contributor

@samuelvl samuelvl commented Nov 16, 2022

Description

Fix RHODS-5910 and RHODS-5836

How Has This Been Tested?

Install 1.18.0-9 and check dashboard-oauth-config secret exists:

$ oc get secret dashboard-oauth-config -n redhat-ods-applications
NAME                     TYPE     DATA   AGE
dashboard-oauth-config   Opaque   1      3m45s

Upgrade to 1.19:

$ oc patch catalogsource addon-managed-odh-catalog \
  --type=merge -p '{"spec":{"image":"quay.io/modh/rhods-operator-live-catalog:1.19.0-rhods-5910"}}' -n openshift-marketplace

Wait until the OAuth objects are created and the dashboard is running:

$ oc get secret dashboard-oauth-config -n redhat-ods-applications
NAME                     TYPE     DATA   AGE
dashboard-oauth-config   Opaque   0      78s

$ oc get secret dashboard-oauth-config-generated -n redhat-ods-applications
NAME                               TYPE     DATA   AGE
dashboard-oauth-config-generated   Opaque   1      84s

$ oc get oauthclient dashboard-oauth-client
NAME                     SECRET                             WWW-CHALLENGE   TOKEN-MAX-AGE
dashboard-oauth-client   FF3kKVNlDauyJlZhb52Q77LtuuhlkWBd   false           default

$ oc get pods -l app=rhods-dashboard -n redhat-ods-applications
NAME                               READY   STATUS    RESTARTS   AGE
rhods-dashboard-869489dfcf-76s2g   2/2     Running   0          3m11s
rhods-dashboard-869489dfcf-dl7b5   2/2     Running   0          88s
rhods-dashboard-869489dfcf-mw74h   2/2     Running   0          3m11s
rhods-dashboard-869489dfcf-ngfps   2/2     Running   0          88s
rhods-dashboard-869489dfcf-xl7px   2/2     Running   0          3m11s

image

Copy link
Contributor

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved and removed lgtm labels Nov 16, 2022
@VaishnaviHire
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2022
@VaishnaviHire VaishnaviHire merged commit d3991ec into red-hat-data-services:rhods-1.19 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants