Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in ServingRuntime ConfigMap enablement #305

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Feb 1, 2023

Description

Fix issue with the deployment of the servingruntimes-config ConfigMap
Fix https://issues.redhat.com/browse/RHODS-6779

How Has This Been Tested?

  • Update from a previous version without a “default-config” key -> A “default-config” key must be created with the latest version in odh-deployer ✅
  • Update from a previous version with a “default-config” key -> We should revert back the default-config, an override-config is targeted for custom deployments ✅
  • Update from a previous version with no configmap -> We need to create the configmap with a default version ✅

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-6779
  • The Jira story is acked.
  • Live build image: quay.io/lferrnan/rhods-operator-live-catalog:1.22.0-rhods-ga
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.

@lucferbux lucferbux requested review from jgarciao and removed request for LaVLaS and pablofelix February 1, 2023 14:30
@openshift-ci
Copy link

openshift-ci bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux by writing /assign @lucferbux in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix issue with the deployment of the servingruntimes-config ConfigMap
Fix https://issues.redhat.com/browse/RHODS-6779
@lucferbux lucferbux force-pushed the fix-servingruntime-configmap-issue-1.22 branch from 327e2f4 to dc6bd7a Compare February 1, 2023 23:00
@VaishnaviHire
Copy link
Contributor

/lgtm

Copy link

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucferbux lucferbux merged commit 7f37d8e into red-hat-data-services:rhods-1.22 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants