Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dspo from odh-deployer. #324

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Remove dspo from odh-deployer. #324

merged 1 commit into from
Apr 12, 2023

Conversation

HumairAK
Copy link
Contributor

Description

Removing dspo from odh deployer

Testing instructions

Deploy via olm install and confirm dspo is not deployed in redhat-ods-applications.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
  • JIRA link(s):
  • [] The Jira story is acked.
  • Live build image:
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • QE contact acknowledges that this has been tested and is approved for merge.

@HumairAK
Remove dspo from odh-deployer.
d45c88d 
Signed-off-by: Humair Khan <humair88@hotmail.com>
@HumairAK
Copy link
Contributor Author

This reverts: #308

@rimolive
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 12, 2023
@jgarciao jgarciao self-requested a review April 12, 2023 13:05
jgarciao
jgarciao approved these changes Apr 12, 2023
View reviewed changes
Copy link

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zdtsw
zdtsw approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgarciao, zdtsw
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive rimolive added the qe-approved The PR has been approved by the QE team label Apr 12, 2023
@accorvin accorvin merged commit d3b3173 into red-hat-data-services:rhods-1.25 Apr 12, 2023
@zdtsw zdtsw mentioned this pull request Apr 12, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@zdtsw zdtsw zdtsw approved these changes

@anishasthana anishasthana Awaiting requested review from anishasthana

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@jgarciao jgarciao

@rimolive rimolive

@zdtsw zdtsw

Labels
lgtm qe-approved The PR has been approved by the QE team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HumairAK @rimolive @jgarciao @zdtsw @accorvin