Dashboard DSG changes

[cfchase]

Create dedicated OAuthclient opendatahub-io/odh-dashboard#658
Generate a random OAuth cookie secret https://github.com/opendatahub-io/odh-dashboard/pull/590/files
Update CRD with disableProjects field

• The commits are squashed in a cohesive manner and have meaningful messages.
• For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
• JIRA link(s):
• The Jira story is acked
• An entry has been added to the latest build document in Build Announcements Folder.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Install using live build quay.io/cfchase/rhods-operator-live-catalog:1.19.0-dashboard-manifests

[cfchase]

Live build: quay.io/cfchase/rhods-operator-live-catalog:1.19.0-dashboard-manifests

[cfchase]

@samuelvl Unfortunately, while a clean install went well, doing an uninstall/reinstall got an error on the dashboard from the oauth-proxy container. Any ideas?

rhods-dashboard-66d77f6f5d-z6t9n-oauth-proxy.log

[samuelvl]

@cfchase Can you share the OAuthClient and secret generated by the controller?

$ oc get oauthclient dashboard-oauth-client -o yaml

$ oc get secret dashboard-oauth-client -o yaml

[samuelvl]

Looks like the OAuthClient object is not deleted when RHODS is uninstalled:

$ oc get oauthclient dashboard-oauth-client -o yaml
...
secret: LiU9o5zJ84ApAZhfYWiA1EQDh93y8pza

$ oc get secret dashboard-oauth-client -n redhat-ods-applications -o yaml
data:
  secret: UNmDsIqyl12hRtMoy5zdwIzWxr6aCxWG

Secrets are different because the secret in the oauthclient object is the secret generated by the first installation and the secret in the secret dashboard-oauth-client is generated by the second installation.

@VaishnaviHire Could you take a look to know why the oauthclient is not deleted during uninstall?

[cfchase]

Thanks @samuelvl .

@VaishnaviHire in addition to handling the delete, would it make sense to regenerate the oauth-client just in case?

[VaishnaviHire]

Yes I am looking into the deletion issue. It has worked previously with ODH deployment so my guess is there are some differences with the Role?

@cfchase We are currently just watching a Secret to manage OauthClient . If we want to go ahead with regenerating the OAuthClient , I think the controller needs to be updated to watch OauthCLient resource as well

[cfchase]

@cfchase We are currently just watching a Secret to manage OauthClient . If we want to go ahead with regenerating the OAuthClient , I think the controller needs to be updated to watch OauthCLient resource as well

Sorry if I'm unfamiliar with how this works. I think my expectation is that if a new secret was created, the dependent oauthclient would either be replaced or fixed by the reconcile. That way, even if there was a stale oauthclient, it would be "fixed" on the new install. Don't let me derail you if that's not the way it should work.