Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add odhdashboardconfig from odh-deployer #441

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add odhdashboardconfig from odh-deployer #441

merged 1 commit into from
Jul 31, 2023

Conversation

VaishnaviHire
Copy link

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s):
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

@VaishnaviHire VaishnaviHire requested a review from zdtsw July 31, 2023 10:15
zdtsw
zdtsw approved these changes Jul 31, 2023
View reviewed changes
Copy link

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

etirelli
etirelli approved these changes Jul 31, 2023
View reviewed changes
Copy link

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VaishnaviHire VaishnaviHire merged commit 5c008cd into red-hat-data-services:master Jul 31, 2023
@VaishnaviHire VaishnaviHire mentioned this pull request Aug 4, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etirelli etirelli etirelli approved these changes

@zdtsw zdtsw zdtsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VaishnaviHire @etirelli @zdtsw