[WIP] 1.3 new UI #125
Merged
[WIP] 1.3 new UI #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently blocked by a bug, will test via jenkins job once it's updated |
lugi0
requested review from
LaVLaS,
bdattoma,
jgarciao,
pablofelix,
tarukumar,
vasukulkarni and
aloganat
tests/Resources/Page/OCPDashboard/InstalledOperators/InstalledOperators.robot
Outdated
Show resolved
Hide resolved
jgarciao
reviewed
Nov 25, 2021
|
I've had to move from openshiftcli to running the oc command directly to fix a test failure due to a timing issue |
jgarciao
reviewed
Nov 26, 2021
tests/Resources/Page/OCPDashboard/InstalledOperators/InstalledOperators.robot
Outdated
Show resolved
Hide resolved
jgarciao
previously approved these changes
Nov 26, 2021
vasukulkarni
previously approved these changes
Nov 30, 2021
|
Please feel free to merge after testing with current build. |
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
bdattoma
reviewed
Jan 11, 2022
bdattoma
reviewed
Jan 11, 2022
bdattoma
reviewed
Jan 11, 2022
bdattoma
previously approved these changes
Jan 11, 2022
|
LGTM. could you run a jenkins job before merging? |
|
I think we will run smoke with this PR before merging |
|
I believe the keyword Maybe you could add a new keyword "Wait Until Spawner Is Loaded" or similar and use it in |
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
|
@jgarciao quick and dirty fix for the keyword for now, we can think of a way to improve it later |
bdattoma
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Giorgi lgiorgi@redhat.com