New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alertmanager Configmap when odh-parameters secret is updated #133
Conversation
0587f9f
to
578cfd7
Compare
578cfd7
to
3a7349d
Compare
Live build is available at quay.io/anishasthana/rhods-operator-live-catalog:1.102.0-1974. |
Lateste live build: quay.io/anishasthana/rhods-operator-live-catalog:1.102.0-1974 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes that are not part of this feature implementation should be reverted
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
3a7349d
to
5bfa591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Although, there are a few blocks of code that I'm not sure if they're related to this feature, if there's something not related to the feature it would be nice to remove it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@anishasthana: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Worked well when updated the emails through UI
lgtm too! |
Signed-off-by: Anish Asthana anishasthana1@gmail.com
[UPSTREAM]
has been prepended to the commit messageTest Instructions:
prometheus
pod inredhat-ods-monitoring
alertmanager
annotationto
emails next touser-notifications
in thealertmanager
configmap.notification-email
key-value pair withingaddon-managed-odh-parameters
secret in theredhat-ods-operator
namespace to have a new email.Related PR: red-hat-data-services/odh-deployer#226