Remove Trustyai installation in downstream #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0be94f0)
VaishnaviHire
force-pushed
the
remove_trusty_downstream
branch
from
b731328
to
d7ccc88
Compare
ruivieira
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM.
@VaishnaviHire I'm assuming removing the component, but keeping the alerting rules won't be an issue?
it is set to disabled, so the alerts wont be added into SRE prometheus regardless what value users set in DSC |
zdtsw
reviewed
Feb 20, 2024
controllers/status/status.go
Outdated
Comment on lines
201
to
203
| if component == trustyai.ComponentName { | ||
| condType = component + "Deprecated" | ||
| } else { |
There was a problem hiding this comment.
think we should not set this,
eventually this status will be removed so not leave a TrustyAIDeprecated in the condition.
VaishnaviHire
force-pushed
the
remove_trusty_downstream
branch
from
86284b9
to
d02edc0
Compare
zdtsw
approved these changes
Feb 20, 2024
VaishnaviHire
merged commit 99116b6
into
red-hat-data-services:rhoai-2.7
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.redhat.com/browse/RHOAIENG-3391
Test Catalogssource: quay.io/vhire/opendatahub-operator-catalog:v2.7.0