fix(monitoring): only deploy role and rolebinding and servicemonitoring for Managed cluster #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Managed cluster only create monitoring NS for Managed cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
changed the title
|
Is this needed for 2.9 ?? |
no, leave it, we need to conclude if namespace is needed first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only create monitoring NS for Managed cluster
ModelMesh has moved away from SRE monitoring. no need redhat-ods-monitoring for Managed cluster.
configureManagedMonitoringonly for management clusterconfigureSegmentfrom oldconfigureCommonMonitoringwhich is called by both Managed and Self-Managed clusterDid a test for upgrade 2.4 to 2.5 to 2.6 on self-managed cluster
the
CleanupExistingResourceduring upgrade handles cleaning resource which was previous deployed by modelmesh so, we do not need namespaceredhat-ods-monitoringany more,live build quay.io/wenzhou/rhods-operator-catalog:v2.10.2761-1
ref: https://issues.redhat.com/browse/RHOAIENG-2761