ray: Cleanup opendatahub Namespace #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaishnaviHire
force-pushed
the
remove_deprecated_namespace
branch
from
c02a36f
to
03a1b01
Compare
zdtsw
reviewed
Apr 17, 2024
Comment on lines
+318
to
+320
| // Remove deprecated opendatahub namespace(owned by kuberay) | ||
| multiErr = multierror.Append(multiErr, deleteDeprecatedNamespace(ctx, cli, "opendatahub")) | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Remove deprecated opendatahub namespace(owned by kuberay) | |
| multiErr = multierror.Append(multiErr, deleteDeprecatedNamespace(ctx, cli, "opendatahub")) | |
| // Remove deprecated opendatahub namespace(owned by kuberay) | |
| if platform == deploy.SelfManagedRhods || platform == deploy.ManagedRhods { | |
| multiErr = multierror.Append(multiErr, deleteDeprecatedNamespace(ctx, cli, "opendatahub")) | |
| } | |
There was a problem hiding this comment.
we only delete it for downstream, right?
There was a problem hiding this comment.
or not needed, if we have checked the ownership by DSC.
Co-authored-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire
merged commit 5820621
into
red-hat-data-services:rhoai-2.9
3 checks passed
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue: https://issues.redhat.com/browse/RHOAIENG-5514