Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(manifests): update dsp, notebook + fix errors #73

Merged
merged 1 commit into from
Oct 23, 2023
Merged

update(manifests): update dsp, notebook + fix errors #73

merged 1 commit into from
Oct 23, 2023

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Oct 21, 2023 •
edited

  • update path to use rhods org not odh org
  • enable notebook, dw, dsp, set to use main/master
  • fix some lint
  • disable unit-test till we can fix the failure first. this is done in the GH not in code.
  • revert logic updated in "modelmesh" till manifests is ready to use, still need point to rhods odh-manifests but keep checking new DSCI on name => this can fix the current "main" with reconciles.
  • fix wrong syntax in CSV causing operator cannot be installed

ref: opendatahub-io#579

quay.io/wenzhou/opendatahub-operator-catalog:v2.10.21-3

@zdtsw zdtsw force-pushed the issue/579 branch 2 times, most recently from 8daf2ac to 534c8ae Compare October 21, 2023 12:22
@zdtsw
update(manifests): update dsp, notebook
6bb1ccb 
- set to main/master for component repo to download manifests
- fix some lint
- fix trustyAI name
- update default instance name in CSV and sample
- revert modelmesh till it can be used with new logic with new manifests

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw marked this pull request as ready for review October 21, 2023 18:02
@zdtsw zdtsw requested a review from etirelli October 22, 2023 08:45
@zdtsw zdtsw changed the title update(manifests): update dsp, notebook update(manifests): update dsp, notebook + fix errors Oct 22, 2023
VaishnaviHire
VaishnaviHire approved these changes Oct 23, 2023
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaishnaviHire VaishnaviHire merged commit 1ecb525 into red-hat-data-services:main Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@etirelli etirelli Awaiting requested review from etirelli

Assignees
No one assigned
Labels
rhods-2.4
Projects
None yet
Milestone
No milestone
2 participants
@zdtsw @VaishnaviHire