Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install deps manually for redhat-rpm-config package #5

Merged
merged 1 commit into from
May 11, 2022
Merged

Install deps manually for redhat-rpm-config package #5

merged 1 commit into from
May 11, 2022

Conversation

samuelvl
Copy link

@samuelvl samuelvl commented May 11, 2022

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-3789
  • The Jira story is acked
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Update the 11.4.2-cuda-s2i-base-ubi8 BuildConfig to use this PR as source:

source:                                                                       
  contextDir: base                                                             
  git:                                                                        
    ref: fix-cuda-buildchain                                                  
    uri: https://github.com/samuelvl/s2i-base-container                       
  type: Git      

Run the CUDA buildchain and wait until it ends:

$ oc get builds
NAME                                        TYPE     FROM          STATUS                       STARTED          DURATION
11.4.2-cuda-s2i-core-ubi8-1                 Docker   Git@f390807   Complete                     8 hours ago      6m30s
11.4.2-cuda-s2i-base-ubi8-5                 Docker   Git@29c7d08   Complete                     42 minutes ago   5m42s
11.4.2-cuda-s2i-py38-ubi8-2                 Docker   Git@4d85c35   Complete                     37 minutes ago   5m40s
11.4.2-cuda-s2i-thoth-ubi8-py38-2           Docker   Git@9c71221   Complete                     31 minutes ago   6m4s
s2i-minimal-gpu-cuda-11.4.2-notebook-2      Docker   Git@fed57a3   Complete                     25 minutes ago   11m24s
s2i-pytorch-gpu-cuda-11.4.2-notebook-1      Source   Git@a71e007   Complete                     14 minutes ago   13m21s
s2i-tensorflow-gpu-cuda-11.4.2-notebook-1   Source   Git@f78e140   Complete                     14 minutes ago   13m59s

@samuelvl samuelvl added the bug Something isn't working label May 11, 2022
@samuelvl samuelvl requested a review from tarukumar May 11, 2022 09:56
@samuelvl samuelvl self-assigned this May 11, 2022
@samuelvl
Copy link
Author

/hold

@samuelvl samuelvl changed the title Remove redhat-rpm-config package for CUDA builds Install deps manually for redhat-rpm-config package May 11, 2022
Copy link

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like this approach. When the package is fixed, it will just work normally, but until then, we'll install what we've got.

@samuelvl samuelvl merged commit 83e1e92 into red-hat-data-services:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants