Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2225433: rbd: do not execute rbd sparsify when volume is in use #172

Merged

Conversation

Rakshith-R
Copy link
Member

This commit makes sure sparsify() is not run when rbd image is in use.
Running rbd sparsify with workload doing io and too frequently is not desirable.
When a image is in use fstrim is run and sparsify will be run only when image is not mapped.

Signed-off-by: Rakshith R rar@redhat.com
(cherry picked from commit 98fdadf) (cherry picked from commit 60a86ab)

This commit makes sure sparsify() is not run when rbd
image is in use.
Running rbd sparsify with workload doing io and too
frequently is not desirable.
When a image is in use fstrim is run and sparsify will
be run only when image is not mapped.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 98fdadf)
(cherry picked from commit 60a86ab)
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

@Rakshith-R: This pull request references Bugzilla bug 2225433, which is invalid:

  • expected the bug to target the "ODF 4.12.5" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2225433: rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Jul 25, 2023
@nixpanic
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit a1b39bf into red-hat-storage:release-4.12 Jul 25, 2023
3 of 10 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

@Rakshith-R: All pull requests linked via external trackers have merged:

Bugzilla bug 2225433 has been moved to the MODIFIED state.

In response to this:

BUG 2225433: rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants