Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2048370: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod #24

Merged

Conversation

Rakshith-R
Copy link
Member

Node reclaimspace request should not be made
when nodeID is empty indicating the pvc is
not mounted to any pod and no volumeattachment
object for that PVC was found.

Signed-off-by: Rakshith R rar@redhat.com
(cherry picked from commit 110c3a5)

Node reclaimspace request should not be made
when nodeID is empty indicating the pvc is
not mounted to any pod and no volumeattachment
object for that PVC was found.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 110c3a5)
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@Rakshith-R: This pull request references Bugzilla bug 2046677, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2046677: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rakshith-R Rakshith-R changed the title Bug 2046677: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod Bug 2048370: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@Rakshith-R: This pull request references Bugzilla bug 2048370, which is invalid:

  • expected the bug to target the "ODF 4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2048370: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 31, 2022

@Rakshith-R do you have required ack's? if not let us know once acks are in place we can approve it.. till you get ack place this PR on hold to avoid accidental merge.

@Rakshith-R
Copy link
Member Author

@Rakshith-R do you have required ack's? if not let us know once acks are in place we can approve it.. till you get ack place this PR on hold to avoid accidental merge.

yes, I've asked for QE ack
👍
/hold

@Rakshith-R
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@Rakshith-R: This pull request references Bugzilla bug 2048370, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jilju.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Rakshith-R: This pull request references Bugzilla bug 2048370, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rakshith-R
Copy link
Member Author

/unhold
/cc @Madhu-1

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 31, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ff2e19e into red-hat-storage:release-4.10 Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@Rakshith-R: All pull requests linked via external trackers have merged:

Bugzilla bug 2048370 has been moved to the MODIFIED state.

In response to this:

Bug 2048370: CSI-Addons controller makes node reclaimspace request even when the PVC is not mounted to any pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants