feat: volume snapshot class

[sp98]

lvmo controller should create volume snapshot class for each deviceclass

Testing:

• Creation of volumesnapshot class by the lvmo controller:

oc get volumesnapshotclass
NAME          DRIVER               DELETIONPOLICY   AGE
odf-lvm-vg1   topolvm.cybozu.com   Delete           5s

• Volume snapshot class:

oc get volumesnapshotclass odf-lvm-vg1 -oyaml
apiVersion: snapshot.storage.k8s.io/v1
deletionPolicy: Delete
driver: topolvm.cybozu.com
kind: VolumeSnapshotClass
metadata:
  creationTimestamp: "2022-05-05T05:01:47Z"
  generation: 1
  name: odf-lvm-vg1
  resourceVersion: "19572561"
  uid: 26c2437c-26ec-4727-8a77-954cd1874c3a

• Deleting the lvm cluster cleans up the volumesnapshot class.
  Signed-off-by: Santosh Pillai sapillai@redhat.com

[nbalacha]

1. We should not be installing the VolumeSnapshotClass CRD. That will be part of the k8s cluster.
2. Please add the rbacs to https://github.com/red-hat-storage/lvm-operator/blob/e611a42df60f183701fe8540b965da7d53dbe93a/controllers/lvmcluster_controller.go#L80

[sp98]

1. We should not be installing the VolumeSnapshotClass CRD. That will be part of the k8s cluster.
   The suite_test would need this CRD to work. Else the tests will faile.

1.6517312682804594e+09	INFO	lvmcluster-controller	topolvm storage class	{"Request.Name": "test-lvmcluster", "Request.Namespace": "openshift-storage", "operation": "created", "name": "odf-lvm-test"}
1.6517312683031378e+09	ERROR	lvmcluster-controller	topolvm volume snapshot class reconcile failure	{"Request.Name": "test-lvmcluster", "Request.Namespace": "openshift-storage", "name": "odf-lvm-test", "error": "no matches for kind \"VolumeSnapshotClass\" in version \"snapshot.storage.k8s.io/v1\""}

Any suggestions to fix this?

2. Please add the rbacs to https://github.com/red-hat-storage/lvm-operator/blob/e611a42df60f183701fe8540b965da7d53dbe93a/controllers/lvmcluster_controller.go#L80

I've added the RBAC annotations above the ensureCreated method of topolvm_snapshotClass.go file. Why do we need to add this in lvmcluster_controller.go? (asking because its not very clear to me).

[nbalacha]

1. We should not be installing the VolumeSnapshotClass CRD. That will be part of the k8s cluster.
   The suite_test would need this CRD to work. Else the tests will faile.

1.6517312682804594e+09	INFO	lvmcluster-controller	topolvm storage class	{"Request.Name": "test-lvmcluster", "Request.Namespace": "openshift-storage", "operation": "created", "name": "odf-lvm-test"}
1.6517312683031378e+09	ERROR	lvmcluster-controller	topolvm volume snapshot class reconcile failure	{"Request.Name": "test-lvmcluster", "Request.Namespace": "openshift-storage", "name": "odf-lvm-test", "error": "no matches for kind \"VolumeSnapshotClass\" in version \"snapshot.storage.k8s.io/v1\""}

Any suggestions to fix this?

Let me think about this. Off the top of my head , set a variable to disable snapshots and set that to true in the make test.

2. Please add the rbacs to https://github.com/red-hat-storage/lvm-operator/blob/e611a42df60f183701fe8540b965da7d53dbe93a/controllers/lvmcluster_controller.go#L80

I've added the RBAC annotations above the ensureCreated method of topolvm_snapshotClass.go file. Why do we need to add this in lvmcluster_controller.go? (asking because its not very clear to me).

Missed that. Having them in the topolvm_snapshotClass.go is better.

[leelavg]

is this required only for non-ocp deployments?

[sp98]

Need to look at how to avoid creating this CRD in lvmo. TestAPI test fails if without the CRD currently. Need to work around that.
"topolvm volume snapshot class reconcile failure","Request.Name":"lvmcluster-sample","Request.Namespace":"lvm-operator-system","name":"odf-lvm-vg1","error":"volumesnapshotclasses.snapshot.storage.k8s.io is forbidden: User \"system:serviceaccount:lvm-operator-system:controller-manager\" cannot create resource \"volumesnapshotclasses\" in API group \"snapshot.storage.k8s.io\" at the cluster scope","stacktrace":"github.com/red-hat-storage/lvm-operator/controllers.(*LVMClusterReconciler).reconcile\n\t/workspace/controllers/lvmcluster_controller.go:180\ngithub.com/red-hat-storage/lvm-operator/controllers.(*LVMClusterReconciler).Reconcile\n\t/workspace/controllers

One suggestion from Nithya was to have a volumesnapshotEnabled flag which is turned off in case of running the tests.

[openshift-ci]

@sp98: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/lvm-operator-bundle-e2e-aws	b15a466	link	false	/test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nbalacha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nbalacha]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@nbalacha: #183 failed to apply on top of branch "release-4.11":

Applying: feat: add volumesnapshotClass resource unit
Applying: feat: add rbac rules for volumesnapshotClass
Applying: feat: go mod changes for volumesnapshotclass
Applying: feat: run make bundle
Applying: test: update e2e to validate snapshot class
Using index info to reconstruct a base tree...
M	e2e/validation.go
Falling back to patching base and 3-way merge...
Auto-merging e2e/validation.go
CONFLICT (content): Merge conflict in e2e/validation.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 test: update e2e to validate snapshot class
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.