Change ManagementState for image registry for non cloud platforms #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petr-balogh
added
Needs Deployment Testing
Fixes: red-hat-storage#1436 Signed-off-by: Petr Balogh <pbalogh@redhat.com>
petr-balogh
force-pushed
the
fix-image-registry-issue-on-vmware
branch
from
b867caf
to
3f5004f
Compare
|
Verification running here: https://ocs4-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/qe-deploy-ocs-cluster/4327/console |
vasukulkarni
reviewed
Feb 5, 2020
| @@ -37,6 +37,15 @@ def change_registry_backend_to_ocs(): | |||
| resource_name=constants.IMAGE_REGISTRY_RESOURCE_NAME, params=param_cmd, format_type='json' | |||
| ), f"Registry pod storage backend to OCS is not success" | |||
|
|
|||
| if(config.ENV_DATA['platform'] not in constants.CLOUD_PLATFORMS): | |||
| run_cmd( | |||
There was a problem hiding this comment.
Is the OK for OCP 4.2 on VMware, the docs in Fixes is pointing to OCP 4.3?
There was a problem hiding this comment.
I do not think that it will have any impact on 4.2 as this is suppose to be default value and in 4.2 it's working with such value by default:
spec:
defaultRoute: true
disableRedirect: false
httpSecret: 868041c963e68caa8eb5b8e7564fffe1c33400336c2db02dc8d4e8a006716b17c6ea74655a1da7ac066e7bfaf6a745f2a47c16491c1ae5b7cbee12869c04c40c
logging: 2
managementState: Managed
petr-balogh
added
Verified
ebenahar
approved these changes
Feb 6, 2020
| logger.info( | ||
| "Waiting 30 seconds after change managementState of image-registry." | ||
| ) | ||
| time.sleep(30) |
There was a problem hiding this comment.
is there something we can sample in order to avoid sleep?
mbukatov
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1436
Signed-off-by: Petr Balogh pbalogh@redhat.com