Retry fetching Noobaa endpoint pods data in case of KeyError #3247
Conversation
tests/conftest.py
Outdated
| @@ -2981,6 +2981,7 @@ def finalizer(): | |||
| request.addfinalizer(finalizer) | |||
|
|
|||
|
|
|||
| @retry.retry(KeyError) | |||
There was a problem hiding this comment.
This is bad, a retry already happens from the calling code in nb_ensure_endpoint_count, we just need to not throw and return False
There was a problem hiding this comment.
good point. Fixed now
Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com>
ebenahar
changed the title
There was a problem hiding this comment.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg
Additional Test Params:
OCP VERSION: 4.6
OCS VERSION: 4.6
Job UNSTABLE (some or all tests failed).
|
The failures in the above run of PR validation are not related to the change done here, marking as verified |
Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com>
There was a problem hiding this comment.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg
Additional Test Params:
OCP VERSION: 4.6
OCS VERSION: 4.6
Job UNSTABLE (some or all tests failed).
…-storage#3247) * Retry fetching Noobaa endpoint pods data Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> fix Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com> * Address comments Signed-off-by: Elad Ben Aharon <ebenahar@redhat.com>
Fixes #3248
Signed-off-by: Elad Ben Aharon ebenahar@redhat.com