Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automates BZ OCS podDisruptionBudget prevents successful OCP upgrades #3888
Automates BZ OCS podDisruptionBudget prevents successful OCP upgrades #3888
Changes from 1 commit
f77b514
f3f2821
39e1df3
12d92fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have osd pdb as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get only OSD PDBs from the list of PDBs so we exclude mons and mds PDBs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it might happen, but if
status
orspec
key will not be available, it will raise exceptionAttributeError: 'NoneType' object has no attribute 'get'
.If it is a valid scenario (that those keys might not be present) and we want to get some default value (
None
in this case), it is better to provide empty dict ({}
) as default value for theget(...)
method:Or if this keys
status
andspec
should be always present, you might use this way:And if it will for some reason happen, that
status
orspec
key are not present, it will raiseKeyError: 'status'
exception, which might be slightly more clear, than theAttributeError: 'NoneType' object has no attribute 'get'
exception mentioned above.