Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Multi-region MCG test #995

Merged

Conversation

Neon-White
Copy link
Member

@Neon-White Neon-White commented Nov 13, 2019

No description provided.

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
* Add namespace parameter to run_mcg_cmd
* Add assertion failure explanations
* Implement oc list_all_bucket_names and verify_bucket_exists
* Fix invalid bucket names caused by capital letters in bucket interface name
* Fix bucket_factory pending the incorrect data to created_bucket_names
* Fix wrong method call `delete_bucket` with `delete_obc`
* Fix incorrect pytest skipif regarding MCGCLI path check
* Replace `noobaa` namespace with `openshift-storage` to comply with MCG integration
* Remove asserts from creation and deletion methods - not the right scope for those
* Remove `MCG not deployed` skip conditions

Signed-off-by: Ben <belimele@redhat.com>
…ply with new bucket_factory

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
- Move skipifs to marks.py
- Replace 'openshift-storage' default namespace with ENV_DATA['cluster_namespace']
- Reduce API calls
- Add docs
- Replace `is False` with `not` in the NooBaa executable checks
- Improve imports

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Refactor 'endpoint' usage to 's3_endpoint'

Signed-off-by: Ben <belimele@redhat.com>
…rtificate

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Fix password retrieval bug

Signed-off-by: Ben <belimele@redhat.com>
…uction

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Replace AWS credential verification system
Change all bucketname listings to return sets instead of lists
Separate multiregion mirror setup to its own fixture
Add a new tier1 test only for creation of a mirrored bucket
Change the old test to a tier2 test
Optimized imports

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job UNSTABLE (some or all tests failed).

Correct documentation of bucket names retrieval functions
Add documentation for `retrieve_test_objects_to_pod` and `sync_object_directory`
Replace recursive copy command with sync
Add missing assert message in the end of `test_multiregion_bucket_creation`
Correct wrong test name (remove redundant `multiregion`)

Signed-off-by: Ben <belimele@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job UNSTABLE (some or all tests failed).

Signed-off-by: Ben <belimele@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job FAILED (installation failed, tests not executed).

…gion-test

Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
ebenahar
ebenahar previously approved these changes Nov 26, 2019
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job PASSED.

@Neon-White Neon-White added the team/manage Manage team related issues/PRs label Nov 27, 2019
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job PASSED.

Signed-off-by: Ben <belimele@redhat.com>
@parikshithb parikshithb self-requested a review November 28, 2019 07:01
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job PASSED.

@Neon-White Neon-White merged commit 1b1293d into red-hat-storage:master Nov 28, 2019
@Neon-White Neon-White deleted the implement-multiregion-test branch November 28, 2019 10:52
parikshithb pushed a commit to parikshithb/ocs-ci that referenced this pull request Jan 24, 2020
* Initial commit
* Documentation cleanup
* Various improvements

* Add namespace parameter to run_mcg_cmd
* Add assertion failure explanations
* Implement oc list_all_bucket_names and verify_bucket_exists
* Fix invalid bucket names caused by capital letters in bucket interface name
* Fix bucket_factory pending the incorrect data to created_bucket_names
* Fix wrong method call `delete_bucket` with `delete_obc`
* Fix incorrect pytest skipif regarding MCGCLI path check
* Replace `noobaa` namespace with `openshift-storage` to comply with MCG integration
* Remove asserts from creation and deletion methods - not the right scope for those
* Remove `MCG not deployed` skip conditions
* Remove missed outdated skipif, fix `test_write_file_to_bucket` to comply with new bucket_factory
* Implement OC bucket creation and deletion mechanisms and tests
* Improve docs
* Improve syntax
* Remove outdated comment
* Implement MCGBucket class
* Remove unused import statement
* Various improvements

- Move skipifs to marks.py
- Replace 'openshift-storage' default namespace with ENV_DATA['cluster_namespace']
- Reduce API calls
- Add docs
- Replace `is False` with `not` in the NooBaa executable checks
- Improve imports
* Improve run_mcg_cmd
* Merge master and change load_yaml_to_dict to load_yaml
* Add missing namespaced bucket creation
* Retrieve proper S3 + MGMT endpoints
Refactor 'endpoint' usage to 's3_endpoint'
* Add `--no-verify-ssl` for AWSCLI commands because of a self-signed certificate
* Add missing s3_endpoint refactor
* Create an InsecureRequestWarning filter marker
* Rename `results2` to be more informative
* Retrieve NooBaa mgmt user and password
* Implement data reduction test

Fix password retrieval bug
* Improve code and docs
* Implement credentials requests and RPC connection creation
* Add missing import
* Various changes

Implement S3 BackingStore bucket creation
Implement OC BS secret creation
Implement OC BS creation
Rename noobaa to MCG in OBC template
Fix credentials request permissions
* Remove unnecessary method, improve docs and variable naming
* Add default namespace to BackingStore yaml
* Fix formatting and remove unneeded return
* Bring back mistakingly deleted return
* Implement BucketClass
* Various improvements

- First draft of the multi region test
- Add missing filterwarnings under test_object_integrity
- Remove credentialsrequest after each test
- Update OBC YAML
- Fix BucketClass YAML
- Add bucketclass option to created buckets
- Implement bucket read/write block toggle
- Implement mirroring verification
- Implement BackingStore state checker
* Various changes

- Improve backingstore creation method
- Add missing namespace to BackingStore and BucketClass creation
- Correct BackingStore state check logging
- Update OC OBC creation to use the new storageClassName system
* Various improvements

- Use classic endpoints when possible (used for region retrieval)
- Fix BackingStore state check
* Extend wait time for BackingStore check timeout
* Improve docs, update S3 region retrieval
* Various changes

- Don't force the user to pass aregion parameter to `create_new_backingstore_bucket` which can cause an exception if the region is `us-east-1`
- Create helper functions for initial download of test files to the AWSCLI pod and for S3 directory syncing
- Improve documentation
* Improve docs, use constants, clean imports
* Rename BucketClass template placeholder
* Remove redundant indentation, return True instead of breaking
* Change cluster region retrieval method
* Implement anonymous object folder syncing
* Add missing object upload, improve test object retrieval command
* Various improvements

Add description to toggle_bucket_readwrite
Break long line under _check_mirroring
Fix test objects sync command to use the correct parameter
* Fix misplaced wget command, pretty doc
* Various improvements

Replace AWS credential verification system
Change all bucketname listings to return sets instead of lists
Separate multiregion mirror setup to its own fixture
Add a new tier1 test only for creation of a mirrored bucket
Change the old test to a tier2 test
Optimized imports
* Fix indent
* Various improvements

Correct documentation of bucket names retrieval functions
Add documentation for `retrieve_test_objects_to_pod` and `sync_object_directory`
Replace recursive copy command with sync
Add missing assert message in the end of `test_multiregion_bucket_creation`
Correct wrong test name (remove redundant `multiregion`)
* Increase mirroring timeout, improve AWS credentials verification
* Improve documentation, improve teardown, clean code
* Correct tiering
* Improve method names

Signed-off-by: Ben <belimele@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/manage Manage team related issues/PRs Test Case A test case PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants