expose option to force remove the OSD in osd removal template #1501

subhamkrai · 2022-02-08T15:04:57Z

adding option to expose --force-osd-removal <true/false>.
It will help when Ceph indicates the OSD is not safe-to-destroy.

Signed-off-by: subhamkrai srai@redhat.com

controllers/storagecluster/job_templates.go

travisn · 2022-02-08T18:37:13Z

controllers/storagecluster/job_templates.go

+			{
+				Name:        "FORCE_OSD_REMOVAL",
+				DisplayName: "FORCE_OSD_REMOVAL",
+				Required:    false,


I believe we also need to specify the default value as:

Value: "false",

Without that I assume the default is just empty, which will likely cause an error in Rook. But we need to test these template changes in an openshift cluster to confirm the default behavior.

I believe we also need to specify the default value as:

Value: "false",

added

Without that I assume the default is just empty, which will likely cause an error in Rook. But we need to test these template changes in an openshift cluster to confirm the default behavior.

I ran oc process FAILED_OSD_IDS=0 ocs-osd-removal | oc create -f - and in job pod the log I see

lag values: --force-osd-removal=false, --help=false, --log-level=DEBUG, --operator-image=, --osd-ids=0, --preserve-pvc=false, --service-account=

so it is adding false by default to force-osd-removal.

controllers/storagecluster/job_templates.go

agarwal-mudit · 2022-02-09T03:37:36Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-02-09T03:37:37Z

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adding option to expose `--force-osd-removal` `<true/false>`. It will help when Ceph indicates the OSD is not safe-to-destroy. Signed-off-by: subhamkrai <srai@redhat.com>

travisn

The changes look good. Can you comment on the testing you've been able to run? From an offline conversation I think it's good to go, but would be good to summarize it here.

subhamkrai · 2022-02-11T02:38:09Z

The changes look good. Can you comment on the testing you've been able to run? From an offline conversation I think it's good to go, but would be good to summarize it here.

So, when running the template without flag force-osd-removal, I was able to verify the default value was false. And when I ran the template with the flag, in the logs I was able to see force-osd-removal=true but osd was not purged because it was healthy(which is expected).

travisn · 2022-02-14T17:58:48Z

/lgtm
@agarwal-mudit @jarrpa Can we get an approve on this?

agarwal-mudit · 2022-02-15T03:51:54Z

/retest

agarwal-mudit · 2022-02-15T04:16:02Z

/approve

openshift-ci · 2022-02-15T04:16:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, subhamkrai, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [agarwal-mudit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-02-15T04:55:40Z

@subhamkrai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws	`9d1e544`	link	false	`/test red-hat-storage-ocs-ci-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2022-02-15T05:15:15Z

@agarwal-mudit: new pull request created: #1518

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2022-08-23T03:53:28Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2022-08-23T03:54:10Z

@subhamkrai: new pull request created: #1778

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2022-08-23T03:55:57Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2022-08-23T03:56:35Z

@subhamkrai: #1501 failed to apply on top of branch "release-4.8":

Applying: expose option to force remove the OSD in osd removal template
Using index info to reconstruct a base tree...
A	controllers/storagecluster/job_templates.go
A	controllers/storagecluster/job_templates_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): controllers/storagecluster/job_templates_test.go deleted in HEAD and modified in expose option to force remove the OSD in osd removal template. Version expose option to force remove the OSD in osd removal template of controllers/storagecluster/job_templates_test.go left in tree.
CONFLICT (modify/delete): controllers/storagecluster/job_templates.go deleted in HEAD and modified in expose option to force remove the OSD in osd removal template. Version expose option to force remove the OSD in osd removal template of controllers/storagecluster/job_templates.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 expose option to force remove the OSD in osd removal template
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2022-08-23T03:57:32Z

@subhamkrai: #1501 failed to apply on top of branch "release-4.8":

Applying: expose option to force remove the OSD in osd removal template
Using index info to reconstruct a base tree...
A	controllers/storagecluster/job_templates.go
A	controllers/storagecluster/job_templates_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): controllers/storagecluster/job_templates_test.go deleted in HEAD and modified in expose option to force remove the OSD in osd removal template. Version expose option to force remove the OSD in osd removal template of controllers/storagecluster/job_templates_test.go left in tree.
CONFLICT (modify/delete): controllers/storagecluster/job_templates.go deleted in HEAD and modified in expose option to force remove the OSD in osd removal template. Version expose option to force remove the OSD in osd removal template of controllers/storagecluster/job_templates.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 expose option to force remove the OSD in osd removal template
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

I'll create manual BP for 4.8, 4.7, 4.6

subhamkrai force-pushed the add-force-osd-purge branch from 63d477e to a3fa73e Compare February 8, 2022 15:24

travisn requested changes Feb 8, 2022

View reviewed changes

openshift-ci bot assigned travisn Feb 8, 2022

expose option to force remove the OSD in osd removal template

9d1e544

adding option to expose `--force-osd-removal` `<true/false>`. It will help when Ceph indicates the OSD is not safe-to-destroy. Signed-off-by: subhamkrai <srai@redhat.com>

subhamkrai force-pushed the add-force-osd-purge branch from a3fa73e to 9d1e544 Compare February 10, 2022 10:32

subhamkrai requested a review from travisn February 10, 2022 10:32

travisn reviewed Feb 10, 2022

View reviewed changes

subhamkrai requested a review from travisn February 11, 2022 08:04

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022

openshift-merge-robot merged commit f06c3e5 into red-hat-storage:main Feb 15, 2022

openshift-cherrypick-robot mentioned this pull request Feb 15, 2022

Bug 2027826: [release-4.10] expose option to force remove the OSD in osd removal template #1518

Merged

subhamkrai deleted the add-force-osd-purge branch February 15, 2022 06:44

openshift-cherrypick-robot mentioned this pull request Aug 23, 2022

Bug 2120260:[release-4.9] expose option to force remove the OSD in osd removal template #1778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expose option to force remove the OSD in osd removal template #1501

expose option to force remove the OSD in osd removal template #1501

subhamkrai commented Feb 8, 2022

travisn Feb 8, 2022

subhamkrai Feb 10, 2022 •

edited

agarwal-mudit commented Feb 9, 2022

openshift-cherrypick-robot commented Feb 9, 2022

travisn left a comment

subhamkrai commented Feb 11, 2022

travisn commented Feb 14, 2022

agarwal-mudit commented Feb 15, 2022

agarwal-mudit commented Feb 15, 2022

openshift-ci bot commented Feb 15, 2022

openshift-ci bot commented Feb 15, 2022

openshift-cherrypick-robot commented Feb 15, 2022

subhamkrai commented Aug 23, 2022

openshift-cherrypick-robot commented Aug 23, 2022

subhamkrai commented Aug 23, 2022

openshift-cherrypick-robot commented Aug 23, 2022

subhamkrai commented Aug 23, 2022

expose option to force remove the OSD in osd removal template #1501

expose option to force remove the OSD in osd removal template #1501

Conversation

subhamkrai commented Feb 8, 2022

travisn Feb 8, 2022

Choose a reason for hiding this comment

subhamkrai Feb 10, 2022 • edited

Choose a reason for hiding this comment

agarwal-mudit commented Feb 9, 2022

openshift-cherrypick-robot commented Feb 9, 2022

travisn left a comment

Choose a reason for hiding this comment

subhamkrai commented Feb 11, 2022

travisn commented Feb 14, 2022

agarwal-mudit commented Feb 15, 2022

agarwal-mudit commented Feb 15, 2022

openshift-ci bot commented Feb 15, 2022

openshift-ci bot commented Feb 15, 2022

openshift-cherrypick-robot commented Feb 15, 2022

subhamkrai commented Aug 23, 2022

openshift-cherrypick-robot commented Aug 23, 2022

subhamkrai commented Aug 23, 2022

openshift-cherrypick-robot commented Aug 23, 2022

subhamkrai commented Aug 23, 2022

subhamkrai Feb 10, 2022 •

edited