fix noobaa uninstall process

[tangledbytes]

Signed-off-by: Utkarsh Srivastava srivastavautkarsh8097@gmail.com

Description

This PR fixes noobaa uninstall process.

NooBaa operator has started to prohibit Noobaa CR deletion by default after a BZ was created, however if spec.cleanupPolicy.allowNoobaaDeletion = true then deletion of CR is allowed. This PR sets spec.cleanupPolicy.allowNoobaaDeletion to true when StorageCluster deletion is reconciled.

Test Performed

OCS operator built from this PR was installed on a fresh openshift cluster.

1. Run and wait for MCG components to come up

$ cat <<EOF | oc create -f -
apiVersion: ocs.openshift.io/v1
kind: StorageCluster
metadata:
  namespace: openshift-storage
  name: example-storagecluster
spec:
  manageNodes: false
  multiCloudGateway:
    reconcileStrategy: standalone

2. Run oc delete noobaas.noobaa.io -n openshift-storage noobaa - Must result in error: rror from server: admission webhook "admissionwebhook.noobaa.io" denied the request: Deletion of NooBaa resource is prohibited
3. Run oc delete storageclusters.ocs.openshift.io -n openshift-storage example-storagecluster - Must be able to delete the Noobaa CR.

[openshift-ci]

Hi @Utkarsh-pro. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tangledbytes]

/assign umangachapagain

[umangachapagain]

/ok-to-test

[umangachapagain]

Put go.mod go.sum and vendor/ changes in 1st commit, hack/common.sh in 2nd commit, make gen-latest-csv changes in 3rd commit and reconciler changes in 4th commit.

We do not want to mix dependency changes with code changes.

[tangledbytes]

@umangachapagain, I have a failing test here. I am not sure if it is related to this PR.

[umangachapagain]

Looks good.
Please add description in commit message for "fix noobaa uninstall" and should be good to merge. You can copy the PR description.

[openshift-ci]

@Utkarsh-pro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws	95f6b43	link	false	/test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jarrpa]

Love to see a good commit structure 👍

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, utkarsh-pro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jarrpa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agarwal-mudit]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@agarwal-mudit: #1698 failed to apply on top of branch "release-4.11":

Applying: update noobaa version to 5.11
Applying: update noobaa operator and core images
Applying: update csv to accomodate noobaa image updates
error: patch failed: deploy/csv-templates/crds/noobaa/noobaa-crd.yaml:15
error: deploy/csv-templates/crds/noobaa/noobaa-crd.yaml: patch does not apply
error: patch failed: deploy/csv-templates/noobaa-csv.yaml:2
error: deploy/csv-templates/noobaa-csv.yaml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	deploy/bundle/manifests/ocs-operator.clusterserviceversion.yaml
Patch failed at 0003 update csv to accomodate noobaa image updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[agarwal-mudit]

@Utkarsh-pro
Do we have a 4.11 BZ for this change?
If yes then we need to backport this change there manually.

[tangledbytes]

@Utkarsh-pro Do we have a 4.11 BZ for this change? If yes then we need to backport this change there manually.

@agarwal-mudit here is the BZ (for 4.11) associated with this PR.

[agarwal-mudit]

@Utkarsh-pro ok, thanks. Can you create a PR to backport the fix to release-4.11 branch?

[tangledbytes]

@agarwal-mudit , just to clarify: I have to create this same PR against release-4.11 branch too right?

[agarwal-mudit]

@Utkarsh-pro Normally we use automated cherry-picking but when that doesn't work because of some conflict (like what is happening in this PR), we have to manually cherry pick (using cherry pick -x [commit-id]) and resolve the conflicts.

[tangledbytes]

@agarwal-mudit is #1717 fine?