Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: add action to build and push images on demand #2616

Merged
merged 1 commit into from
May 17, 2024

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@iamniting iamniting force-pushed the push branch 7 times, most recently from 69917e2 to 9ba740c Compare May 17, 2024 09:46
@iamniting
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@malayparida2000
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/override ci/prow/ocs-operator-bundle-e2e-aws

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ocs-operator-bundle-e2e-aws

In response to this:

/override ci/prow/ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 05df196 into red-hat-storage:main May 17, 2024
11 checks passed
@openshift-cherrypick-robot

@iamniting: new pull request created: #2617

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting iamniting deleted the push branch May 17, 2024 10:44
leelavg added a commit to leelavg/ocs-client-operator that referenced this pull request May 27, 2024
relates to red-hat-storage/ocs-operator#2616, when ocs or odf operator
is deployed by u/s CI they try to pull a preconfigured bundle of
ocs-client-operator for deployment however that bundle is being created
on demand manually.

Having a working gh-action for performing that op reduces manual work,
at the same time trying to keep the action as short as possible we
should set the vars correctly that corresponds to a particular release
in Makefile.

Below is an example on how it was done manually
```
export VERSION=4.16.0
export IMG=quay.io/ocs-dev/ocs-client-operator:v${VERSION}
export OCS_CLIENT_CONSOLE_IMG=\
quay.io/ocs-dev/ocs-client-console:v4.15.0
export BUNDLE_IMG=quay.io/ocs-dev/ocs-client-operator-bundle:v${VERSION}
```

Apart from above, client-op depends on csi-addons and for u/s, again we
are creating & pushing a bundle for that operator and use the relavent
image tags of csi-addons, which will still be manual op atm.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants