-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: add action to build and push images on demand #2616
Conversation
69917e2
to
9ba740c
Compare
/cherry-pick release-4.16 |
@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/ocs-operator-bundle-e2e-aws |
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ocs-operator-bundle-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
05df196
into
red-hat-storage:main
@iamniting: new pull request created: #2617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
relates to red-hat-storage/ocs-operator#2616, when ocs or odf operator is deployed by u/s CI they try to pull a preconfigured bundle of ocs-client-operator for deployment however that bundle is being created on demand manually. Having a working gh-action for performing that op reduces manual work, at the same time trying to keep the action as short as possible we should set the vars correctly that corresponds to a particular release in Makefile. Below is an example on how it was done manually ``` export VERSION=4.16.0 export IMG=quay.io/ocs-dev/ocs-client-operator:v${VERSION} export OCS_CLIENT_CONSOLE_IMG=\ quay.io/ocs-dev/ocs-client-console:v4.15.0 export BUNDLE_IMG=quay.io/ocs-dev/ocs-client-operator-bundle:v${VERSION} ``` Apart from above, client-op depends on csi-addons and for u/s, again we are creating & pushing a bundle for that operator and use the relavent image tags of csi-addons, which will still be manual op atm. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
Signed-off-by: Nitin Goyal nigoyal@redhat.com