do not check for storageconsumer when storagerequest is being deleted #2618
Conversation
|
An alternate implementation is not doing a get on storageconsumer from storagerequest controller at all, that also seemed clean but didn't find strong reasons to prefer one over other. |
|
/cherry-pick release-4.16 |
|
@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/test ocs-operator-bundle-e2e-aws |
there is a possibility that getting storageconsumer from cache would work even when the resource is deleted however if the event gets requeued then we will always hit failure while trying to get deleted resource after a cache sync. with this commit we only check presence of storageconsumer if storagerequest is not being deleted as the deletion of storagerequest is generally triggered via owner references and storageconsumer is owner of storagerequest. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 9adb14d
into
red-hat-storage:main
|
@leelavg: new pull request created: #2626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
there is a possibility that getting storageconsumer from cache would work even when the resource is deleted however if the event gets requeued then we will always hit failure while trying to get deleted resource after a cache sync.
with this commit we only check presence of storageconsumer if storagerequest is not being deleted as the deletion of storagerequest is generally triggered via owner references and storageconsumer is owner of storagerequest.
fix for https://bugzilla.redhat.com/show_bug.cgi?id=2280813