Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageCluster: remove node taints during uninstall #560

Merged
merged 1 commit into from
Jun 15, 2020
Merged

StorageCluster: remove node taints during uninstall #560

merged 1 commit into from
Jun 15, 2020

Conversation

raghavendra-talur
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2020
@raghavendra-talur
StorageCluster: remove node taints during uninstall
6c1d49d 
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2020
@obnoxxx
Copy link
Contributor

obnoxxx commented Jun 11, 2020

/test ocs-operator-e2e-aws

@openshift-ci-robot
Copy link

@raghavendra-talur: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 6c1d49d link /test red-hat-storage-ocs-ci-e2e-aws
ci/prow/ocs-operator-e2e-aws 6c1d49d link /test ocs-operator-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

obnoxxx
obnoxxx approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@obnoxxx
Copy link
Contributor

obnoxxx commented Jun 15, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx, raghavendra-talur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 42fe1e3 into red-hat-storage:master Jun 15, 2020
@raghavendra-talur raghavendra-talur deleted the rtalur-delete-node-taints branch June 20, 2020 02:35
@raghavendra-talur raghavendra-talur mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@jarrpa jarrpa Awaiting requested review from jarrpa

@umangachapagain umangachapagain Awaiting requested review from umangachapagain

Assignees

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raghavendra-talur @obnoxxx @openshift-ci-robot @openshift-merge-robot