Refactor: Moving the logic for modifying/creating CephCluster #567
Conversation
|
@jarrpa @umangachapagain Do we need to run |
anubhav-here-zz
changed the title
anubhav-here-zz
changed the title
There was a problem hiding this comment.
A good start, but you're missing a few things. For example: https://github.com/openshift/ocs-operator/blob/abe7d2792dc94e760f895e0bd3b2ea809b254160/pkg/controller/storagecluster/reconcile.go#L726-L823
Look through all the functions in reconcile.go. If any of them ar eonly called via the ensureCephCluster() or newCephCluster() functions (like the two above) then they belong in the new file as well.
Signed-off-by: Anubhav Deep <adeep@redhat.com>
anubhav-here-zz
force-pushed
the
refactor
branch
from
abe7d27
to
48be5cf
Compare
|
@jarrpa Addressed the changes requested! |
|
@anubhav-here: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anubhav-here, jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test ocs-operator-e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Moved the logic related to
CephClusterto a new file in the same package.Signed-off-by: Anubhav Deep adeep@redhat.com