Updated the clean up application resource message #1375
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SanjalKatiyar , @GowthamShanmugam Please review |
locales/en/plugin__odf-console.json
Outdated
| @@ -150,7 +150,7 @@ | |||
| "Relocated to cluster {{ preferredCluster }}": "Relocated to cluster {{ preferredCluster }}", | |||
| "Completed": "Completed", | |||
| "FailingOver to cluster {{ failoverCluster }}": "FailingOver to cluster {{ failoverCluster }}", | |||
| "Cleanup of resources requires user attention. Finish cleanup to restart replication.": "Cleanup of resources requires user attention. Finish cleanup to restart replication.", | |||
| "Clean up application resources/application workload on current primary cluster {{ failoverCluster }} to start the relocation.": "Clean up application resources/application workload on current primary cluster {{ failoverCluster }} to start the relocation.", | |||
There was a problem hiding this comment.
The error message is different for Failover and relocates actions.
Also, the failover & relocate error message will differ for regional and metro.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2277125 Signed-off-by: Timothy Asir Jeyasingh <tjeyasin@redhat.com>
TimothyAsirJeyasing
force-pushed
the
cleanup-message-bz2277125
branch
from
d08cf27
to
6d5bf8e
Compare
| description: t('Relocating to cluster {{ preferredCluster }}', { | ||
| preferredCluster, | ||
| }), |
There was a problem hiding this comment.
why does the relocating status have to be removed?
| description: t( | ||
| 'Clean up application resources on current primary cluster {{failoverCluster}} to start the relocation.', | ||
| { | ||
| failoverCluster, | ||
| } | ||
| ), |
There was a problem hiding this comment.
I dont see any check for cleanup in progress
| preferredCluster, | ||
| }), | ||
| description: t( | ||
| 'Clean up application resources on current primary cluster {{failoverCluster}} to start the relocation.', |
There was a problem hiding this comment.
Here, the message says current primary but the placeholder is referring to {{failoverCluster}}, it is confusing.
| 'Clean up application resources on failed cluster {{failoverCluster}} to start the replication.', | ||
| { | ||
| failoverCluster, | ||
| } | ||
| ), | ||
| status: t('Pending'), | ||
| icon: <PendingIcon />, | ||
| }; | ||
| } else { | ||
| return { | ||
| description: t( | ||
| 'Clean up application resources on failed cluster {{failoverCluster}}.', | ||
| { | ||
| failoverCluster, | ||
| } |
There was a problem hiding this comment.
No need to repeat everything, just message is differs for Async and sync
| return { | ||
| description: t('FailedOver to cluster {{failoverCluster}}', { | ||
| failoverCluster, | ||
| }), | ||
| status: t('Completed'), | ||
| icon: <GreenCheckCircleIcon />, |
There was a problem hiding this comment.
Optimize this failover/relocate/cleanup checks
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2277125