Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install dr-cluster in the namespace dr hub is installed #113

Merged
merged 3 commits into from May 31, 2022

Conversation

weirdwiz
Copy link
Contributor

@weirdwiz weirdwiz commented May 9, 2022

this commit adds a function, that gets the list of all the subscriptions
and returns the namespace of the subscription with the name "odr-dr-system"

Signed-off-by: Divyansh Kamboj dkamboj@redhat.com

@vbnrh
Copy link
Member

vbnrh commented May 10, 2022

we also need to change the place where openshift-dr-systems are hardcoded for the s3 secret sync

@vbnrh
Copy link
Member

vbnrh commented May 17, 2022

DRCluster is cluster-scoped as part of RamenDR/ramen#444
We can just remove the namespace for it.

Other changes will still need to be applied.

this commit adds a function, that gets the list of all the subscriptions
and returns the namespace of the subscription with the name "odr-dr-system"

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
Copy link
Member

@vbnrh vbnrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Lets sqaush it into three commits

  1. For the actual changes
  2. Test changes
  3. Generated changes

@@ -12,7 +12,7 @@ spec:
listKind: DRClusterList
plural: drclusters
singular: drcluster
scope: Namespaced
scope: Cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for this ! Can you check if this CRD matches with what the Ramen has currently ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this matches ramen's CRD

controllers/common_controller_utils_test.go Outdated Show resolved Hide resolved
this commit updates ramen dependency, install ramen operator config in
the namespace where the pod is running.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
this commit also removes the namespace for drcluster.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vbnrh, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e6e0cdd into red-hat-storage:main May 31, 2022
@vbnrh
Copy link
Member

vbnrh commented May 31, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot

@vbnrh: new pull request created: #119

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants