Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makefile] Allow local builds by using make local #76

Merged

Conversation

black-dragon74
Copy link
Collaborator

@black-dragon74 black-dragon74 commented Oct 26, 2023

Fixes: #77

Note: You still need to export ODF_MG_TOKEN.

Example: ODF_MG_TOKEN=<MY_TOKEN_HERE> make local

This builds and tags the image as "odf-mg". You can override it using IMG_TAG environment variable.

P.S: If using rancher, just export RANCHER variable in the ENV.

Extended example: RANCHER=yes ODF_MG_TOKEN=<TOKEN_HERE> IMG_TAG=my-custom-tag make local

Regards

Note: You still need to export `ODF_MG_TOKEN`.

Example: `ODF_MG_TOKEN=<MY_TOKEN_HERE> make local`

This builds and tags the image as "odf-mg". You can override it
using `IMG_TAG` environment variable.

P.S: If using rancher, just export RANCHER variable in the ENV.

Extended example: `RANCHER=yes ODF_MG_TOKEN=<TOKEN_HERE> IMG_TAG=my-custom-tag make local`

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [black-dragon74,yati1998]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 5445ca9 into red-hat-storage:main Oct 26, 2023
5 checks passed
@yati1998
Copy link
Member

/cherry-pick release-4.13

@openshift-cherrypick-robot

@yati1998: #76 failed to apply on top of branch "release-4.13":

Applying: Allow local builds by using `make local`
.git/rebase-apply/patch:60: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow local builds by using `make local`
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Allow local builds using Makefile
3 participants