bundle: start creating file based catalog instead of sqlite #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
iamniting
force-pushed
the
opm
branch
3 times, most recently
from
b7c2e2f
to
bb03974
Compare
|
The workflow is failing as code for accessing the secret is added into the same PR I guess. |
jarrpa
reviewed
Sep 16, 2022
Sqlite-based catalogs and their related subcommands are deprecated. Support for them will be removed in a future release. Ref: https://olm.operatorframework.io/docs/reference/file-based-catalogs/ https://olm.operatorframework.io/docs/reference/veneers/ Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
docker local cache prevents opm render to pull new bundle images even if they are changed unless we change the image tag. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
As opm render is running inside a container while making a container image it does not have a access to the local registry and fails to render odf-operator-bundle image. To render odf-operator-bundle we will have to push it to the internet where it is publically accesable or we can use the opm binary directly on the machine instead of using it inside container. It will push it to ocs-dev for now. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
done, I missed it earlier |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sqlite-based catalogs and their related subcommands are deprecated.
Support for them will be removed in a future release.
Ref:
https://olm.operatorframework.io/docs/reference/file-based-catalogs/
https://olm.operatorframework.io/docs/reference/veneers/
Signed-off-by: Nitin Goyal nigoyal@redhat.com