Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2238922: Add concurrent access protection to the event recorder #140

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

rakeshgm
Copy link
Member

Signed-off-by: Benamar Mekhissi bmekhiss@ibm.com
(cherry picked from commit a3498a4)

Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
(cherry picked from commit a3498a4)
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@rakeshgm: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add concurrent access protection to the event recorder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rakeshgm rakeshgm changed the title Add concurrent access protection to the event recorder Bug 2238922: Add concurrent access protection to the event recorder Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@rakeshgm: This pull request references Bugzilla bug 2238922, which is invalid:

  • expected the bug to target the "ODF 4.12.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2238922: Add concurrent access protection to the event recorder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kseegerrh
Copy link

kseegerrh commented Sep 14, 2023

/bugzilla refresh

1 similar comment
@kseegerrh
Copy link

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@kseegerrh: This pull request references Bugzilla bug 2238922, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.8) matches configured target release for branch (ODF 4.12.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @parikshithb

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: parikshithb.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@kseegerrh: This pull request references Bugzilla bug 2238922, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.8) matches configured target release for branch (ODF 4.12.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @parikshithb

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@BenamarMk BenamarMk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenamarMk, rakeshgm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenamarMk BenamarMk merged commit 9adf856 into red-hat-storage:release-4.12 Sep 14, 2023
5 of 6 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@rakeshgm: All pull requests linked via external trackers have merged:

Bugzilla bug 2238922 has been moved to the MODIFIED state.

In response to this:

Bug 2238922: Add concurrent access protection to the event recorder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants