This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
workaround python-jenkins-0.2.1's build_job() #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktdreyer
force-pushed
the
python-jenkins-0.2.1
branch
from
129074f
to
97d40b1
Compare
Prior to this change, the system version of Ubuntu Trusty's python-jenkins did not properly submit new jobs to Jenkins. The problem was that Jenkins expected a POST request, and python-jenkins-0.2.1 sent a GET request instead. To force python-jenkins to send a POST, copy upstream's solution (https://bugs.launchpad.net/python-jenkins/+bug/1177831) and pass an empty string to urllib2's Request constructor. The new "_has_broken_build_job()" method checks to see if we have a buggy python-jenkins version, and if not, we just fall through to the original behavior (without monkeypatching). This commit could be reverted if we ever require a newer Ubuntu OS version (like Xenial) with a newer/less-buggy python-jenkins package.
I test with 0.2.1 since that's what's in Ubuntu Trusty; older versions are not supported.
ktdreyer
force-pushed
the
python-jenkins-0.2.1
branch
from
97d40b1
to
e2088d3
Compare
|
@tserlin FYI this will be fixed in v1.1.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the system version of Ubuntu Trusty's python-jenkins did not properly submit new jobs to Jenkins. The problem was that Jenkins expected a POST request, and python-jenkins-0.2.1 sent a GET request instead.
To force python-jenkins to send a POST, copy upstream's solution (https://bugs.launchpad.net/python-jenkins/+bug/1177831) and pass an empty string to urllib2's Request constructor. The new
_has_broken_build_job()method checks to see if we have a buggy python-jenkins version, and if not, we just fall through to the original behavior (without monkeypatching).This commit could be reverted if we ever require a newer Ubuntu OS version (like Xenial) with a newer/less-buggy python-jenkins package.