Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1888713: ceph: fix mon pdb reconcile #137

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Bug 1888713: ceph: fix mon pdb reconcile #137

merged 1 commit into from
Oct 22, 2020

Conversation

sp98
Copy link

@sp98 sp98 commented Oct 22, 2020 •
edited

updated mon pdb reconcile to delete mon pdb and create a new one when mon count changes in the cluster spec

(cherry picked from commit 28cd611)
Signed-off-by: Santosh Pillai sapillai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@openshift-ci-robot
Copy link

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BZ 1888713: ceph: fix mon pdb reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title BZ 1888713: ceph: fix mon pdb reconcile Bug 1888713: ceph: fix mon pdb reconcile Oct 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 22, 2020
@openshift-ci-robot
Copy link

@sp98: This pull request references Bugzilla bug 1888713, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "OCS 4.6.0" instead
  • expected Bugzilla bug 1888713 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1888713: ceph: fix mon pdb reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98
ceph: fix mon pdb reconcile
d23cbae 
updated mon pdb reconcile to delete mon pdb and create a new one when mon count changes in the cluster spec

(cherry picked from commit 28cd611)
Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@openshift-ci-robot
Copy link

@sp98: This pull request references Bugzilla bug 1888713, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "OCS 4.6.0" instead
  • expected Bugzilla bug 1888713 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1888713: ceph: fix mon pdb reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn merged commit e5d1048 into red-hat-storage:release-4.6 Oct 22, 2020
@openshift-ci-robot
Copy link

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 1888713 has been moved to the MODIFIED state.

In response to this:

Bug 1888713: ceph: fix mon pdb reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
3 participants
@sp98 @openshift-ci-robot @travisn