Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1982805: Use v1 CronJob and PDB resources if available instead of v1beta1 #284

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

travisn
Copy link

@travisn travisn commented Aug 20, 2021

Description of your changes:
Use v1 CronJob and PDB resources if available. In order for their API to be available, we also pull in the update to the client-go API and controller runtime.

Which issue is resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=1982805

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

subhamkrai and others added 4 commits August 20, 2021 13:03
this commit update cronjob from v1beta1 to v1

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f82fc46)
(cherry picked from commit 229b550)
The v1beta1 cronjob is deprecated and needs to use v1 for K8s 1.16 and newer

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 07ddcda)
(cherry picked from commit ca1c574)
this commit bump controller runtime version
to 0.9 and kubernetes version to v1.21.1.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 382ca4a)
This commit update the PodDisruptionBudget policy to use version v1
Updated to policy/v1 as policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+

Closes: rook#7917
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 77813f7)
@travisn travisn added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 20, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2021

@travisn: This pull request references Bugzilla bug 1982805, which is invalid:

  • expected the bug to target the "OCS 4.8.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982805: Use v1 CronJob and PDB resources if available instead of v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2021

@agarwal-mudit: This pull request references Bugzilla bug 1982805, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (OCS 4.8.2) matches configured target release for branch (OCS 4.8.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 30, 2021
@openshift-ci openshift-ci bot requested a review from ebenahar August 30, 2021 08:41
@agarwal-mudit
Copy link
Member

/hold cancel

@agarwal-mudit
Copy link
Member

@travisn @leseb This PR can be merged, needs approve/lgtm labels.

@leseb leseb merged commit be3b92b into red-hat-storage:release-4.8 Aug 31, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2021

@travisn: All pull requests linked via external trackers have merged:

Bugzilla bug 1982805 has been moved to the MODIFIED state.

In response to this:

Bug 1982805: Use v1 CronJob and PDB resources if available instead of v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn deleted the backport-v1-updates branch February 24, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch.
Projects
None yet
5 participants