Bug 1994588: ceph: fix panic when recreating the csidriver object #287
Conversation
Initialize the client and the csidriver object before calling the reCreateCSIDriverInfo function. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit d48f67a)
log the successful message about starting CSIDriver after creating the daemonset and deployment objects. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit e2dc418)
remove csiDriver and csiClient variables creation and reuse them from the method receivers. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit d246dde)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Yuggupta27 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yuggupta27
changed the title
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @Yuggupta27. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Yuggupta27: An error was encountered querying GitHub for users with public email (pbalogh@redhat.com) for bug 1994588 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
@Yuggupta27: This pull request references Bugzilla bug 1994588, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pbalogh@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@agarwal-mudit can we merge? |
Yes |
|
/lgtm |
|
@Yuggupta27: All pull requests linked via external trackers have merged: Bugzilla bug 1994588 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of your changes:
This PR fixes the below items
Initialize the client and the csidriver object before calling the reCreateCSIDriverInfo function.
reuse already defined csiDriver object instead of referring to the method receiver
log the successful message about starting CSIDriver after creating the daemonset and deployment objects.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
Note: the issue was reported at slack https://rook-io.slack.com/archives/CK9CF5H2R/p1629776387282600
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.