New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2049075: csi: cleanup csi driver resources when zero cephclusters exist #346
Bug 2049075: csi: cleanup csi driver resources when zero cephclusters exist #346
Conversation
This commit modifies ceph-csi controller to be able to cleanup ceph-csi deployment,daemonset,services & csidriver objects when no cephcluster exists. It makes the following changes: - redundant check for tp.DriverNamePrefix is removed. - retry to start drivers within reconcile loop is removed, controller will retry in case of error now. - stopDrivers() will now return error in case of failure. - predicate delete func will now respond to cephcluster deletion. - CSI resources will be cleaned up when cephcluster does not exist. Fixes: rook#9697 Signed-off-by: Rakshith R <rar@redhat.com> (cherry picked from commit 1e9920f) (cherry picked from commit 2027e7f)
@Rakshith-R: This pull request references Bugzilla bug 2049075, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ammahapa@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @red-hat-storage/rook-admins @agarwal-mudit @red-hat-storage/ceph-csi-admins |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leseb, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rakshith-R: All pull requests linked via external trackers have merged: Bugzilla bug 2049075 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit modifies ceph-csi controller to be able to cleanup
ceph-csi deployment,daemonset,services & csidriver objects
when no cephcluster exists.
It makes the following changes:
controller will retry in case of error now.
Fixes: rook#9697
Signed-off-by: Rakshith R rar@redhat.com
(cherry picked from commit 1e9920f)
(cherry picked from commit 2027e7f)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.