Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundTripAuthenticationValidator docs show type is passed invalidate callback #2

Open
D010101 opened this issue Jun 24, 2019 · 1 comment

Comments

@D010101
Copy link

D010101 commented Jun 24, 2019

The docs for the RoundTripAuthenticationValidator state that the "type" is passed in the invalidate endpoint call:
https://github.com/red5pro/red5pro-simple-auth-plugin/blob/master/red5proroundtripauthvalidator.md#invalidate-credentials

However, the type parameter is not passed in the call. I looked at the code and the invalidate callback appears to only apply to publisher connections, not subscriber connections.

if (conn.hasAttribute("roletype") && conn.getStringAttribute("roletype").equals("publisher")

Not sure if just the docs need to be corrected, or if the functionality in the invalidate is missing the type parameter in the invalidate callback.

@rajdeeprath
Copy link

I believe it will be a doc update. invalidate is used to destroy the token which is obtained through /login call to the remote server. Since the token is not issued based on type, the invalidate call too does not need the type parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants