Refactor #8
Merged
Refactor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed cyclic dependency message <-> backend - Moved logic from message to rbforwarder. Messages is now a simple struct.
- Components can import package "pipeline" instead the whole rbforwarder package - Component Helpers are not needed anymore - Produce now takes a second arguments to pass user data - Refactored tests
Bigomby
force-pushed
the
feature/refactor
branch
from
a9aa6f8
to
46d25eb
Compare
Bigomby
force-pushed
the
feature/refactor
branch
from
c804e5a
to
1516dc0
Compare
Bigomby
force-pushed
the
feature/refactor
branch
from
1516dc0
to
5691d8a
Compare
Not multiple getReports() can be used
Message limiting will be implemented as a module
Bigomby
force-pushed
the
feature/refactor
branch
2 times, most recently
from
e519f23
to
620aaf4
Compare
- Report type now is only for presentation. No logic at all. - New message handler to deal with retries and reporting - More interfaces. Less implementation details. - Reduced complexity (less gorutines, less channels, less is more)
- New backend allows to create a custom pipeline - Safe way to close channels
Bigomby
force-pushed
the
feature/refactor
branch
from
620aaf4
to
154bacc
Compare
Bigomby
added a commit
that referenced
this pull request
Oct 3, 2016
Refactor the application to make it simplier. The point is to have a minimal core and multiple reusable plugins to add functionality. - No bidirectional references between structs. - Remove logic that can be built into a plugin (limiter) - Safe use of channels - Use interfaces to hide implementation - Loosely coupled modules - Reporter - Pipeline Closes #6
Bigomby
added a commit
that referenced
this pull request
Oct 18, 2016
Refactor the application to make it simplier. The point is to have a minimal core and multiple reusable plugins to add functionality. - No bidirectional references between structs. - Remove logic that can be built into a plugin (limiter) - Safe use of channels - Use interfaces to hide implementation - Loosely coupled modules - Reporter - Pipeline Closes #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the application to make it simplier. The point is to have a minimal core and multiple reusable plugins to add functionality.
Closes #6