Add runtime to red service list #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manegron
commented
May 27, 2024
manegron
commented
- New option: red service list -r or red service list --runtime to show runtime of services
|
The Label Bot has predicted the following:
|
ljblancoredborder
requested changes
May 27, 2024
There was a problem hiding this comment.
We can use always prints on line 60 and 62 instead of doing differentiation, making the if content shorter. The same can be applied on 101 and 107
Color GREEN,YELLOW,RED can be parametrized, in order to collapse repeated code from 74 to 96 into a def function
If we expect to increase the number of arguments, we should create a def for the arguments (line 25)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.