Feature see guest responses #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature-see-guest-responses complete Merge conflicts resolved
BlakeTurner
suggested changes
Mar 29, 2017
| <View style={styles.imageView}> | ||
| {(guest[1] === '+' && <Image source={inviteConfirmationStatus.YES.imageSource} />) | ||
| || (guest[1] === '-' && <Image source={inviteConfirmationStatus.NO.imageSource} />) | ||
| || <Image source={inviteConfirmationStatus.UNKNOWN.imageSource} />} |
There was a problem hiding this comment.
This is terrifying. It's nice to see that you understand short circuits, but this one goes pretty far!
You should write a function that takes a guest (or whatever guest[1] is) and returns an image component.
| inviteResponses[key].forEach((item) => { | ||
| guestResponses.push([item, '?']); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Suggest a refactor to write a function:
const createGuestResponse = (key, item) => {
const responseMap = {
userAccept: [`${item.firstName} ${item.lastName}`, '+'],
userReject: [`${item.firstName} ${item.lastName}`, '-'],
...etc
}
return responseMap[key];
}And just throw in a guard clause to handle the inviteResponses[key].length > 0 repetition.
|
|
||
| const getPotluckInviteResponses = (potluckId) => { | ||
| const promises = [ | ||
| processtPotluckUserInviteResponses(potluckId, getGuestInviteUserDetailsAccept) || [], |
BlakeTurner
approved these changes
Mar 29, 2017
|
PR issues actioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes issue #25