Added New Screens to allow the ability to add potlucks. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeTurner
suggested changes
Mar 16, 2017
js/components/InfoForm/index.js
Outdated
| getValueInOnChange: (text) => text, | ||
| debounce: 500, | ||
| }, | ||
| Theme: { |
There was a problem hiding this comment.
Why is this one uppercase?
| onChangeHandler: 'onChangeText', | ||
| props: { | ||
| placeholder: 'Potluck Name', | ||
| style: styles.login |
js/components/InfoForm/index.js
Outdated
| }, | ||
| } | ||
| super(fields); | ||
| this.state.date = new Date() |
There was a problem hiding this comment.
Use newlines to separate concerns. the call to super should have a newline after it
js/components/InfoForm/index.js
Outdated
| this.state.arriveTime = new Date() | ||
| this.state.servingTime = new Date() | ||
| } | ||
| onDateChange = (date) => { |
There was a problem hiding this comment.
Add newlines between methods
js/components/InfoForm/index.js
Outdated
| arriveTime: time | ||
| }) | ||
| } | ||
| onServingTimeChange = (time) => { |
|
|
||
| class FoodScreenContainer extends Component { | ||
| constructor() { | ||
| super() |
There was a problem hiding this comment.
If you don't define a constructor you don't need to call super
| onChangeText={(text) => { | ||
| (onTextChange(text)) | ||
| }} /> | ||
| <View> |
There was a problem hiding this comment.
Indentation is 1 too deep here
| <View style={styles.buttonContainer}> | ||
| <TouchableHighlight | ||
| style={[styles.button, styles.inactive]} | ||
| onPress={() => (onIncrease())} |
There was a problem hiding this comment.
Function name is weird here. On press, you increase, right? So it should be:
onPress={() => (increase())}When you name something on[Action] the function should be an event handler.
| </TouchableHighlight> | ||
| <TouchableHighlight | ||
| style={[styles.button, styles.active]} | ||
| onPress={() => (onDecrease())} |
| constructor() { | ||
| super() | ||
| this.state = { | ||
| text: 0 |
There was a problem hiding this comment.
Should it be called text? Or count?
BlakeTurner
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 4 Screens to add potlucks. Closes #13