styled signup scene #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeTurner
suggested changes
Mar 22, 2017
| <Text style={styles.errorMessage}> | ||
| {fields.password.errorMessage && fields.password.errorMessage} | ||
| </Text> | ||
| </View> |
There was a problem hiding this comment.
My challenge to you: write a component that encapsulates
<View style={styles.errorContainer}>
<Text style={styles.errorMessage}>
{fields.password.errorMessage && fields.password.errorMessage}
</Text>
</View>And works w/ Gandalf. Maybe name it something like ValidatedText.
BlakeTurner
suggested changes
Mar 23, 2017
| validators: ['required'], | ||
| errorPropName: 'error', | ||
| onChangeHandler: 'onChangeText', | ||
| props: { | ||
| placeholder: 'Password', | ||
| style: styles.login |
There was a problem hiding this comment.
You're going to want to add the secureTextEntry: true prop here. This will make it behave like a password input.
| validators: ['email'], | ||
| errorPropName: 'error', | ||
| onChangeHandler: 'onChangeText', | ||
| props: { | ||
| placeholder: 'Email', | ||
| style: styles.login |
There was a problem hiding this comment.
We can use keyboardType: 'email-address' here.
There was a problem hiding this comment.
We should also use autoCapitalize: false here.
There was a problem hiding this comment.
Just make sure you add those props to the ValidatedText component
BlakeTurner
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #82