fix phpstan error (#5155)

redaxo · Jun 11, 2022 · d324493 · d324493
1 parent b183b85
commit d324493
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/.tools/phpstan/baseline.neon b/.tools/phpstan/baseline.neon
@@ -70,11 +70,6 @@ parameters:
 			count: 1
 			path: ../../redaxo/src/addons/structure/pages/index.php
 
-		-
-			message: "#^Variable \\$prevCtype in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: ../../redaxo/src/addons/structure/plugins/content/lib/article_content_base.php
-
 		-
 			message: "#^Right side of && is always true\\.$#"
 			count: 1

diff --git a/redaxo/src/addons/structure/plugins/content/lib/article_content_base.php b/redaxo/src/addons/structure/plugins/content/lib/article_content_base.php
@@ -703,7 +703,7 @@ private function renderSlices(string $articleLimit, string $sliceLimit): void
                 if ('edit' != $this->mode && !$this->eval) {
                     if (0 == $i) {
                         $articleContent = "<?php\n\nif (\$this->ctype == '".$sliceCtypeId."' || \$this->ctype == '-1') {\n";
-                    } elseif (isset($prevCtype) && $sliceCtypeId != $prevCtype) {
+                    } elseif (null !== $prevCtype && $sliceCtypeId != $prevCtype) {
                         // ----- zwischenstand: ctype .. wenn ctype neu dann if
                         $articleContent .= "}\n\nif (\$this->ctype == '".$sliceCtypeId."' || \$this->ctype == '-1') {\n";
                     }