Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added phpunit problem matcher #3209

Merged
merged 9 commits into from
Jan 25, 2020
Merged

Added phpunit problem matcher #3209

merged 9 commits into from
Jan 25, 2020

Conversation

staabm
Copy link
Member

@staabm staabm commented Jan 24, 2020 •
edited
Loading

Closes #3169

@staabm
Copy link
Member Author

staabm commented Jan 24, 2020

Here we go.. annotations für unit tests

@staabm
Copy link
Member Author

staabm commented Jan 24, 2020

Hmm der 7.3 build auf travis läuft durch.. auf githubaction gibts nen error im rex_timer_test

@staabm
Copy link
Member Author

staabm commented Jan 24, 2020

Hmm vllt läuft die Bedingung anders..

redaxo/redaxo/src/core/lib/util/timer.php

Line 54 in 3929a9b

$enabled = rex::isDebugMode() || ($user = rex::getUser()) && $user->isAdmin();

@staabm staabm requested review from gharlan and bloep January 25, 2020 08:17
@staabm staabm added the automerge Automatisch PR rebasen und mergen label Jan 25, 2020
@kodiakhq kodiakhq bot merged commit 3b5ec73 into master Jan 25, 2020
@kodiakhq kodiakhq bot deleted the staabm-patch-4 branch January 25, 2020 10:15
@staabm staabm mentioned this pull request Jan 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gharlan gharlan Awaiting requested review from gharlan

@bloep bloep Awaiting requested review from bloep

Assignees
No one assigned
Labels
automerge Automatisch PR rebasen und mergen
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phpunit github action
1 participant
@staabm