support non-falsy-string in rex_sql::escape()
#5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
non-falsy-string in rex_sql::escape()non-falsy-string in rex_sql::escape()
staabm
commented
Oct 4, 2022
| @@ -1405,7 +1405,10 @@ private function fetchMeta() | |||
| * @param string $value den zu escapenden Wert | |||
| * | |||
| * @return string | |||
There was a problem hiding this comment.
interessant dass der cs-fixer das @return string unten entfernt hat, hier aber nicht
There was a problem hiding this comment.
Einmal steht es ja als nativer Return type dran
There was a problem hiding this comment.
Ich meinte diesen commit 0174ae5
There was a problem hiding this comment.
Ja, da wurde es entfernt, weil string schon als nativer Return type an der Methode steht.
Hier bei der Methode gibt es hingegen keinen nativen return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ich hab kein konretes issue oder nutzen, aber
non-falsy-stringist ein präziserer type wienon-empty-stringund sollte daher wenn möglich erhalten bleiben